feat: Prefetch links on Artwork screen #11650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olerichter00
force-pushed
the
olerichter00/ONYX-1582/prefetch-links-on-artwork-screen
branch
from
e42c7e7 to
7b84d5b
Compare
olerichter00
commented
Mar 13, 2025
| @@ -132,32 +130,10 @@ export const PartnerQueryRenderer: React.FC<{ | |||
| partnerID: string | |||
| isVisible: boolean | |||
| }> = ({ partnerID, ...others }) => { | |||
| const { loading } = useClientQuery<PartnerInitialQuery>({ | |||
There was a problem hiding this comment.
This isn't doing anything, just delaying the initial load, so I removed it.
olerichter00
requested review from
dariakoko and
nickskalkin
and removed request for
MounirDhahri
nickskalkin
approved these changes
Mar 14, 2025
| } | ||
| } | ||
| `} | ||
| cacheConfig={{ force: true }} |
There was a problem hiding this comment.
I wonder why we had this force: true here before
| } | ||
| } | ||
| `} | ||
| query={ArtistSeriesScreenQuery} | ||
| cacheConfig={{ force: true }} |
There was a problem hiding this comment.
@olerichter00 I've noticed that here you do not remove force: true, but in ArtistSeriesFullArtistSeriesList.tsx you do. Is it intentional?
| @@ -155,23 +142,26 @@ const ArtistListItem: React.FC<Props> = ({ | |||
| return null | |||
| } | |||
|
|
|||
| const navigateOnPress = !disableNavigation && !onPress | |||
There was a problem hiding this comment.
took me some time to understand this. I wonder if a comment could be helpful here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1582
Description
Prefetch links on Artwork screen.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.